RFR: 8360122: Fix java.sql\Connection.java indentation [v2]
Roger Riggs
rriggs at openjdk.org
Mon Jun 23 17:38:29 UTC 2025
On Mon, 23 Jun 2025 17:18:13 GMT, simon <duke at openjdk.org> wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> ---------
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an issue
>>
>>
>>
>> ### Reviewing
>> <details><summary>Using <code>git</code></summary>
>>
>> Checkout this PR locally: \
>> `$ git fetch https://git.openjdk.org/jdk.git pull/25925/head:pull/25925` \
>> `$ git checkout pull/25925`
>>
>> Update a local copy of the PR: \
>> `$ git checkout pull/25925` \
>> `$ git pull https://git.openjdk.org/jdk.git pull/25925/head`
>>
>> </details>
>> <details><summary>Using Skara CLI tools</summary>
>>
>> Checkout this PR locally: \
>> `$ git pr checkout 25925`
>>
>> View PR using the GUI difftool: \
>> `$ git pr show -t 25925`
>>
>> </details>
>> <details><summary>Using diff file</summary>
>>
>> Download this PR as a diff file: \
>> <a href="https://git.openjdk.org/jdk/pull/25925.diff">https://git.openjdk.org/jdk/pull/25925.diff</a>
>>
>> </details>
>> <details><summary>Using Webrev</summary>
>>
>> [Link to Webrev Comment](https://git.openjdk.org/jdk/pull/25925#issuecomment-2993856738)
>> </details>
>
> simon has updated the pull request incrementally with one additional commit since the last revision:
>
> 8360122: refactor code formatting to enforce 100 chars line length limit for improved readability
src/java.sql/share/classes/java/sql/Connection.java line 1597:
> 1595: default boolean setShardingKeyIfValid(ShardingKey shardingKey,
> 1596: ShardingKey superShardingKey,
> 1597: int timeout) throws SQLException {
I haven't quite identified your preferred formatting style.
>From previous reformattings with multiple arguments, the exception was placed on a line by itself.
(Generally, we defer to the original/previous author's choice of line breaks and formatting.
Choosing only to reformat to use a consistent style within each file/class or package.)
The issue title and PR title should be a bit more general, its more than just indentation cleanup.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2162126095
More information about the core-libs-dev
mailing list