RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

[simon]

On Mon, 23 Jun 2025 17:35:50 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8360122: refactor code formatting to enforce 100 chars line length limit for improved readability
>
> src/java.sql/share/classes/java/sql/Connection.java line 1597:
> 
>> 1595:     default boolean setShardingKeyIfValid(ShardingKey shardingKey,
>> 1596:                                           ShardingKey superShardingKey,
>> 1597:                                           int timeout) throws SQLException {
> 
> I haven't quite identified your preferred formatting style.
> From previous reformattings with multiple arguments, the exception was placed on a line by itself.
> 
> (Generally, we defer to the original/previous author's choice of line breaks and formatting. 
> Choosing only to reformat to use a consistent style within each file/class or package.)
> 
> The issue title and PR title should be a bit more general, its more than just indentation cleanup.

@RogerRiggs My preferred formatting style is like this: 


    default boolean setShardingKeyIfValid(ShardingKey shardingKey,
                                          ShardingKey superShardingKey,
                                          int timeout) throws SQLException {


But as you said, there is previous reformattings that does not follow it. If you agree, I will fix them. What do you thing about it?

About the issue title and PR title, we can make it more general like: 

"Improve Readability and Maintainability of Connection.java"

What your suggestion on it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2162305006