RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v5]

Thomas Schatzl tschatzl at openjdk.org
Tue Mar 4 08:24:54 UTC 2025


On Mon, 3 Mar 2025 20:02:16 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   * fix comment (trailing whitespace)
>>   * another assert when snapshotting at a safepoint.
>
> src/hotspot/share/gc/g1/g1ConcurrentRefineStats.hpp line 43:
> 
>> 41:   size_t _cards_clean;                // Number of cards found clean.
>> 42:   size_t _cards_not_parsable;         // Number of cards we could not parse and left unrefined.
>> 43:   size_t _cards_still_refer_to_cset;  // Number of cards marked still young.
> 
> `_cards_still_refer_to_cset` from the naming it is not clear what the difference is with `_cards_refer_to_cset`, the comment is not helping with that

`cards_still_refer_to_cset` refers to cards that were found to have already been marked as `to-collection-set`. Renamed to `_cards_already_refer_to_cset`, would that be okay?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r1978868225


More information about the core-libs-dev mailing list