RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v5]

Thomas Schatzl tschatzl at openjdk.org
Tue Mar 4 08:39:56 UTC 2025


On Tue, 4 Mar 2025 08:22:03 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1ConcurrentRefineStats.hpp line 43:
>> 
>>> 41:   size_t _cards_clean;                // Number of cards found clean.
>>> 42:   size_t _cards_not_parsable;         // Number of cards we could not parse and left unrefined.
>>> 43:   size_t _cards_still_refer_to_cset;  // Number of cards marked still young.
>> 
>> `_cards_still_refer_to_cset` from the naming it is not clear what the difference is with `_cards_refer_to_cset`, the comment is not helping with that
>
> `cards_still_refer_to_cset` refers to cards that were found to have already been marked as `to-collection-set`. Renamed to `_cards_already_refer_to_cset`, would that be okay?

Fwiw, this is just for statistics, so if you want I can remove these. I did some experiments with re-examining these cards too to see whether we could clear them later. For determining if/when to do that a rate of increase for the young cards has been interesting.

As mentioned, if you want I can remove them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r1978896272


More information about the core-libs-dev mailing list