RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea
Joe Darcy
darcy at openjdk.org
Thu Mar 6 00:31:54 UTC 2025
On Wed, 5 Mar 2025 15:16:03 GMT, Eric Caspole <ecaspole at openjdk.org> wrote:
> The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH which seemed to make it more of a SQE test than a benchmark. We would prefer to keep benchmarks as benchmarks as much as possible and not creep into tests.
Marked as reviewed by darcy (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/23917#pullrequestreview-2662793406
More information about the core-libs-dev
mailing list