RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea
Eric Caspole
ecaspole at openjdk.org
Thu Mar 6 19:51:47 UTC 2025
On Wed, 5 Mar 2025 16:40:55 GMT, Chen Liang <liach at openjdk.org> wrote:
>> The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH which seemed to make it more of a SQE test than a benchmark. We would prefer to keep benchmarks as benchmarks as much as possible and not creep into tests.
>
> Also might need to add an 2025 copyright header for this file.
Thanks @liach I removed the unused Blackhole and updated the copyright header.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23917#issuecomment-2704796397
More information about the core-libs-dev
mailing list