RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]
Joe Wang
joehw at openjdk.org
Tue Mar 18 19:58:08 UTC 2025
On Tue, 18 Mar 2025 18:26:09 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update the test: change variables and etc.
>
> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/w3c/dtd/schema10/XMLSchema.dtd line 8:
>
>> 6: <!-- prose copy in the structures REC is the definitive version --> <!--d-->
>> 7: <!-- (which shouldn't differ from this one except for this --> <!--d-->
>> 8: <!-- comment and entity expansions, but just in case) --> <!--d-->
>
> The other XML comments use the multi-line format with a single begin
> What is the meaning of ""?
> Is "REC" a typo?
> The comment seems unnecessarily apologetic. It should be sufficient to say:
> Note: this DTD is NOT normative, any differences from RFC XXX are insidential". (or similar).
Makes sense. The question would be, would we want to modify the standard file?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24039#discussion_r2001886194
More information about the core-libs-dev
mailing list