RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

Roger Riggs rriggs at openjdk.org
Wed Mar 19 13:48:13 UTC 2025


On Tue, 18 Mar 2025 19:55:39 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/w3c/dtd/schema10/XMLSchema.dtd line 8:
>> 
>>> 6: <!-- prose copy in the structures REC is the definitive version -->    <!--d-->
>>> 7: <!-- (which shouldn't differ from this one except for this -->         <!--d-->
>>> 8: <!-- comment and entity expansions, but just in case) -->              <!--d-->
>> 
>> The other XML comments use the multi-line format with a single begin 
>> What is the meaning of ""?
>> Is "REC" a typo?
>> The comment seems unnecessarily apologetic. It should be sufficient to say:
>> Note: this DTD is NOT normative, any differences from RFC XXX are insidential". (or similar).
>
> Makes sense. The question would be, would we want to modify the standard file?

Likely, a number of my comments were due to comparing with the wrong XMLSchema.data version.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24039#discussion_r2003370242


More information about the core-libs-dev mailing list