RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]
KIRIYAMA Takuya
duke at openjdk.org
Fri Mar 21 09:05:27 UTC 2025
> The current test program for the logging feature added in JDK-8301627 does not fully check some important cases.
>
> Issue Details:
> The test does not properly check cases where logging might not happen due to different logging levels. (e.g. ALL, TRACE, WARNING, etc.)
> The check for the logged stack trace is not enough, as it does not confirm enough details in the output.
>
> Fix Details:
> Added more test cases to check behavior under different logging levels.
> Improved the stack trace check by verifying more details in the logged output.
> These changes make the test more complete and ensure that the logging feature works as expected.
> Also, any existing test cases prior to this pull request are retained.
>
> The test was verified in the following OS environments, and it passed successfully in both environments.
> - Windows Server 2022 Standard 21H2
> - Red Hat Enterprise Linux release 9.2 (Plow)
>
> Could you please review this fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24050/files
- new: https://git.openjdk.org/jdk/pull/24050/files/9437726b..68024f93
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24050&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24050&range=00-01
Stats: 11 lines in 8 files changed: 0 ins; 0 del; 11 mod
Patch: https://git.openjdk.org/jdk/pull/24050.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24050/head:pull/24050
PR: https://git.openjdk.org/jdk/pull/24050
More information about the core-libs-dev
mailing list