RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

Roger Riggs rriggs at openjdk.org
Tue Mar 25 18:42:10 UTC 2025


On Fri, 21 Mar 2025 09:06:14 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> test/jdk/java/lang/RuntimeTests/ExitLogging-FINER.properties line 8:
>> 
>>> 6: 
>>> 7: java.util.logging.ConsoleHandler.level = ALL
>>> 8: java.lang.Runtime.level = FINER
>> 
>> It is a waste of resources to test every combination of logger levels.
>> This is not a test of the filtering mechanism built into the logger; it is a test that the message is logged when the logger level is set to DEBUG or finer.
>> Only two test cases are needed for that.
>
> I see. This test only takes a very short time, but shouldn't the cases be added?

Still no, starting a new Java runtime isn't that quick, and it brings no additional value.
All tests are run 10's of thousands of times in every release, adding a few seconds here and there add up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24050#discussion_r2012734770


More information about the core-libs-dev mailing list