RFR: 8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" [v2]

[Brent Christian]

On Fri, 21 Mar 2025 14:24:16 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename counter variables to use 'Count'
>
> test/jdk/java/lang/ref/FinalizerHistogramTest.java line 45:
> 
>> 43:     static ReentrantLock lock = new ReentrantLock();
>> 44:     static final AtomicInteger wasInitialized = new AtomicInteger(0);
>> 45:     static final AtomicInteger wasTrapped = new AtomicInteger(0);
> 
> Minor: Do you think the name might be confusing? May be naming `wasInitialized` and `wasTrapped` as `initialisedCount` and `trappedCount` might be more descriptive, what do you think?

Works for me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24143#discussion_r2008138540