RFR: 8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" [v3]

Brent Christian bchristi at openjdk.org
Fri Mar 21 18:55:09 UTC 2025


On Fri, 21 Mar 2025 14:24:19 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   'return' not needed in lambda
>
> test/jdk/java/lang/ref/FinalizerHistogramTest.java line 72:
> 
>> 70:             // GC and wait for at least 2 MyObjects to be ready for finalization,
>> 71:             // and one MyObject to be stuck in finalize().
>> 72:             ForceGC.wait(() -> { return ref1.refersTo(null) &&
> 
> Nitpick: I think you don't need a { return ....} here, it can be a pure lambda afaik. But if you prefer this way, I don't mind in the slightest 😃

Correct 🙂

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24143#discussion_r2008154439


More information about the core-libs-dev mailing list