RFR: 8352689: Allow for hash sum overrides when linking from the run-time image [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Wed Mar 26 13:45:14 UTC 2025
On Wed, 26 Mar 2025 08:28:23 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Copyright updates
>> - Allow for ${java.home} substitution when \@file is being passed
>>
>> Also refactor the tests. One using the CLI, the other using
>> the @file-base version of the option.
>
> test/jdk/tools/jlink/runtimeImage/ModifiedFilesWithShaOverrideTest.java line 32:
>
>> 30: * @requires (vm.compMode != "Xcomp" & os.maxMemory >= 2g & os.family == "linux")
>> 31: * @library ../../lib /test/lib
>> 32: * @enablePreview
>
> Do you know why @enablePreview is necessary here?
It escapes me now and a bit of digging I think this was due to the fact JEP 493 being developed along side JEP 484 (ClassFile API). At the time some helpers in jlink tests used the ClassFile API and was still in preview at the time.
It no longer seems to be needed, so let me remove those.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24190#discussion_r2014175084
More information about the core-libs-dev
mailing list