RFR: 8352689: Allow for hash sum overrides when linking from the run-time image [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Thu Mar 27 10:36:16 UTC 2025
On Wed, 26 Mar 2025 13:42:11 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> test/jdk/tools/jlink/runtimeImage/ModifiedFilesWithShaOverrideTest.java line 32:
>>
>>> 30: * @requires (vm.compMode != "Xcomp" & os.maxMemory >= 2g & os.family == "linux")
>>> 31: * @library ../../lib /test/lib
>>> 32: * @enablePreview
>>
>> Do you know why @enablePreview is necessary here?
>
> It escapes me now and a bit of digging I think this was due to the fact JEP 493 being developed along side JEP 484 (ClassFile API). At the time some helpers in jlink tests used the ClassFile API and was still in preview at the time.
>
> It no longer seems to be needed, so let me remove those.
Fixed in the latest update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24190#discussion_r2016191606
More information about the core-libs-dev
mailing list