RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v2]

Naoto Sato naoto at openjdk.org
Wed Mar 26 20:57:47 UTC 2025


> Those system property values on Windows were derived from Windows' `GetConsoleCP()` call, but they should have been taken from `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one won't change any behavior, as both calls return the same value by default (`GetOEMCP()`). However, it is still the right thing to do.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Reflects the review comment

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24263/files
  - new: https://git.openjdk.org/jdk/pull/24263/files/12ca7f9e..7d80adcc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24263&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24263&range=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/24263.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24263/head:pull/24263

PR: https://git.openjdk.org/jdk/pull/24263


More information about the core-libs-dev mailing list