RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v2]

Brian Burkhalter bpb at openjdk.org
Wed Mar 26 21:08:07 UTC 2025


On Wed, 26 Mar 2025 20:57:47 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Those system property values on Windows were derived from Windows' `GetConsoleCP()` call, but they should have been taken from `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one won't change any behavior, as both calls return the same value by default (`GetOEMCP()`). However, it is still the right thing to do.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reflects the review comment

Approving `boolean` -> `BOOL` update.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24263#pullrequestreview-2718619286


More information about the core-libs-dev mailing list