RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

Naoto Sato naoto at openjdk.org
Thu Mar 27 16:03:08 UTC 2025


> Those system property values on Windows were derived from Windows' `GetConsoleCP()` call, but they should have been taken from `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one won't change any behavior, as both calls return the same value by default (`GetOEMCP()`). However, it is still the right thing to do.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Handled the error case

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24263/files
  - new: https://git.openjdk.org/jdk/pull/24263/files/7d80adcc..5475497e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24263&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24263&range=01-02

  Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/24263.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24263/head:pull/24263

PR: https://git.openjdk.org/jdk/pull/24263


More information about the core-libs-dev mailing list