RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

[Alan Bateman]

On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Those system property values on Windows were derived from Windows' `GetConsoleCP()` call, but they should have been taken from `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one won't change any behavior, as both calls return the same value by default (`GetOEMCP()`). However, it is still the right thing to do.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Handled the error case

src/java.base/windows/native/libjava/java_props_md.c line 131:

> 129: }
> 130: 
> 131: static char* getConsoleEncoding(BOOL output)

I assume the "output" param is to prepare for introducing stdin.encoding in the future.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24263#discussion_r2017033301