RFR: 8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX

Matthias Baesken mbaesken at openjdk.org
Fri May 2 08:13:44 UTC 2025


On Fri, 2 May 2025 07:59:12 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Seems the currently used ATTRIBUTE_NO_UBSAN does not handle the exclusion of float divisions by zero.
>> At least this is the case on AIX.
>> 
>> (seen in the jtreg test java/lang/Math/PowTests.java )
>
> src/hotspot/share/sanitizers/ub.hpp line 39:
> 
>> 37: #define ATTRIBUTE_NO_UBSAN __attribute__((no_sanitize("undefined","float-divide-by-zero")))
>> 38: #endif
>> 39: #if defined(__GNUC__) && !defined(__clang__)
> 
> Maybe use `#elif`?

Or should I try to set it for BOTH clang and gcc so that the added checks are not needed any more?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24963#discussion_r2071258909


More information about the core-libs-dev mailing list