RFR: 8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX

Lutz Schmidt lucy at openjdk.org
Sun May 4 12:30:46 UTC 2025


On Fri, 2 May 2025 08:11:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> src/hotspot/share/sanitizers/ub.hpp line 39:
>> 
>>> 37: #define ATTRIBUTE_NO_UBSAN __attribute__((no_sanitize("undefined","float-divide-by-zero")))
>>> 38: #endif
>>> 39: #if defined(__GNUC__) && !defined(__clang__)
>> 
>> Maybe use `#elif`?
>
> Or should I try to set it for BOTH clang and gcc so that the added checks are not needed any more?

If you change it to #elif, then please do it in both files.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24963#discussion_r2072605220


More information about the core-libs-dev mailing list