RFR: 8353232: Standardizing and Unifying XML Component Configurations
Joe Wang
joehw at openjdk.org
Wed May 7 16:22:33 UTC 2025
This is a refactor patch, no change in functionality.
This patch refactor the configuration code. Rather than for each factory to go through the whole configuration process, a base configuration as represented in JdkXmlConfig is created once, which includes loading of the JAXP Configuration file, factories then get their own copies of the property managers, created on top of the base ones rather than directly constructed.
The JDKCatalogResolver is lazily constructed as needed instead of created along with the security manager.
The rest of changes basically replace all direct constructions of XMLSecurityManager/XMLSecurityPropertyManager with calls to JdkXmlConfig's corresponding get methods, which return clones of the base instances. in the factory classes, these clones are updated with property settings on the factories. In non-public or legacy code paths (inherited from upstream components), such updates may not be necessary.
Tests: existing tests T1-3 passed; XML JCK tests passed.
-------------
Commit messages:
- 8353232: Standardizing and Unifying XML Component Configurations
Changes: https://git.openjdk.org/jdk/pull/25102/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25102&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8353232
Stats: 582 lines in 31 files changed: 318 ins; 119 del; 145 mod
Patch: https://git.openjdk.org/jdk/pull/25102.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25102/head:pull/25102
PR: https://git.openjdk.org/jdk/pull/25102
More information about the core-libs-dev
mailing list