RFR: 8353232: Standardizing and Unifying XML Component Configurations

[Lance Andersen]

On Wed, 7 May 2025 16:17:07 GMT, Joe Wang <joehw at openjdk.org> wrote:

> This is a refactor patch, no change in functionality.
> 
> This patch refactor the configuration code. Rather than for each factory to go through the whole configuration process, a base configuration as represented in JdkXmlConfig is created once, which includes loading of the JAXP Configuration file, factories then get their own copies of the property managers, created on top of the base ones rather than directly constructed.
> 
> The JDKCatalog and its Resolver are lazily initialized when external references are encountered. This code replaces the original code block within the security manager. This change also addresses JDK-8350189.
> 
> The rest of changes basically replace all direct constructions of XMLSecurityManager/XMLSecurityPropertyManager with calls to JdkXmlConfig's corresponding get methods, which return clones of the base instances. in the factory classes, these clones are updated with property settings on the factories. In non-public or legacy code paths (inherited from upstream components), such updates may not be necessary.
> 
> Tests: existing tests T1-3 passed; XML JCK tests passed.

Hi Joe,

This looks good overall.

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25102#pullrequestreview-2822928555