RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v4]

Raffaello Giulietti rgiulietti at openjdk.org
Thu May 15 13:38:06 UTC 2025


On Tue, 13 May 2025 21:24:08 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> Some changes in `Biginteger`s' bit operations that increase the code readability and slightly optimize the execution time.
>
> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update names

Since you are at it, I'd suggest changing `javaIncrement` to be `static` (no need to change access).

Also, if you find remnants of C-style array notation, like `int newMag[]`, it would be nice to have them as `int[] newMag`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25166#issuecomment-2883843995


More information about the core-libs-dev mailing list