RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v4]

fabioromano1 duke at openjdk.org
Thu May 15 13:43:53 UTC 2025


On Thu, 15 May 2025 13:35:29 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update names
>
> Since you are at it, I'd suggest changing `javaIncrement` to be `static` (no need to change access).
> 
> Also, if you find remnants of C-style array notation, like `int newMag[]`, it would be nice to have them as `int[] newMag`.

@rgiulietti And what about the [suggestion](https://github.com/openjdk/jdk/pull/25166#discussion_r2083561722) of @liach?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25166#issuecomment-2883862016


More information about the core-libs-dev mailing list