RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v2]
Roger Riggs
rriggs at openjdk.org
Mon May 19 19:40:52 UTC 2025
On Mon, 19 May 2025 18:40:56 GMT, ExE Boss <duke at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>>
>> move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 209:
>
>> 207: super(-1, 0, cap, cap, fd, isSync, segment);
>> 208: address = addr;
>> 209: cleaner = (unmapper == null) ? null : BufferCleaner.register(this, unmapper);
>
> **OpenJDK** unfortunately uses the less accessible spaces[^1]:
> Suggestion:
>
> cleaner = (unmapper == null) ? null : BufferCleaner.register(this, unmapper);
>
>
> [^1]: - prettier/prettier#7475
> - https://alexandersandberg.com/tabs-for-accessibility/
OpenJDK has not considered adoption of tabs-for-accessibility and sticks to using spaces across the codebase.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25289#discussion_r2096367503
More information about the core-libs-dev
mailing list