RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v2]
Kim Barrett
kbarrett at openjdk.org
Mon May 19 20:22:52 UTC 2025
On Mon, 19 May 2025 19:37:58 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 209:
>>
>>> 207: super(-1, 0, cap, cap, fd, isSync, segment);
>>> 208: address = addr;
>>> 209: cleaner = (unmapper == null) ? null : BufferCleaner.register(this, unmapper);
>>
>> **OpenJDK** unfortunately uses the less accessible spaces[^1]:
>> Suggestion:
>>
>> cleaner = (unmapper == null) ? null : BufferCleaner.register(this, unmapper);
>>
>>
>> [^1]: - prettier/prettier#7475
>> - https://alexandersandberg.com/tabs-for-accessibility/
>
> OpenJDK has not considered adoption of tabs-for-accessibility and sticks to using spaces across the codebase.
I didn't notice that a tab had snuck in there. Thanks for spotting.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25289#discussion_r2096427690
More information about the core-libs-dev
mailing list