RFR: 8356128: Correct documentation for --linux-package-deps
Alexey Semenyuk
asemenyuk at openjdk.org
Tue May 20 16:56:58 UTC 2025
On Fri, 14 Feb 2025 15:01:35 GMT, Stefan Lobbenmeier <duke at openjdk.org> wrote:
> The documentation suggests that --linux-package-deps is a boolean option, while in fact it is a string option with dependencies separated by comma and space
>
> You can tell that this option is supposed to have an argument here: https://github.com/openjdk/jdk/blob/fea5f2b1458cdd53f437e59caaffaa6e22fb59a7/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java#L366-L372
Changes requested by asemenyuk (Reviewer).
src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties line 298:
> 296: \ --linux-menu-group <menu-group-name>\n\
> 297: \ Menu group this application is placed in\n\
> 298: \ --linux-package-deps <package-dep>[, <package-dep>...]\n\
The value of this CLI option is a string, not a comma-separated string list. For jpackage it is a "pass through" value.
Maybe
--linux-package-deps <package-dep-string>\n\
?
-------------
PR Review: https://git.openjdk.org/jdk/pull/23638#pullrequestreview-2816429421
PR Review Comment: https://git.openjdk.org/jdk/pull/23638#discussion_r2074396184
More information about the core-libs-dev
mailing list