RFR: 8356128: Correct documentation for --linux-package-deps [v2]
Stefan Lobbenmeier
duke at openjdk.org
Wed May 21 10:02:54 UTC 2025
On Wed, 21 May 2025 09:57:10 GMT, Stefan Lobbenmeier <duke at openjdk.org> wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties line 298:
>>
>>> 296: \ --linux-menu-group <menu-group-name>\n\
>>> 297: \ Menu group this application is placed in\n\
>>> 298: \ --linux-package-deps <package-dep>[, <package-dep>...]\n\
>>
>> The value of this CLI option is a string, not a comma-separated string list. For jpackage it is a "pass through" value.
>> Maybe
>>
>> --linux-package-deps <package-dep-string>\n\
>>
>> ?
>
> it is a comma separated string list for the underlying implementation but you would need to quote it so it is passed as a single arg. But I agree we can simplify this to <package-dep-string>
>
> Suggestion:
>
> \ --linux-package-deps <package-dep-string>\n\
As in, this worked in my testing: `--linux-package-deps "foo, bar"`, see https://github.com/JetBrains/compose-multiplatform/pull/5227#issuecomment-2659470908
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23638#discussion_r2099882692
More information about the core-libs-dev
mailing list