RFR: 8366178: Implement JEP 526: Lazy Constants (Second Preview) [v25]
Per Minborg
pminborg at openjdk.org
Fri Nov 14 15:15:51 UTC 2025
On Wed, 12 Nov 2025 16:08:19 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 112 commits:
>>
>> - Clarify toString spec
>> - Merge branch 'master' into lazy-constants
>> - Add @AOTSafeClassInitializer
>> - Address comments in PR
>> - Fix merge mistake
>> - Merge master
>> - Rework toString implementations
>> - Update after doc comments
>> - Merge branch 'master' into lazy-constants
>> - Revert the AbstractMap.keySet @Stable annotation
>> - ... and 102 more: https://git.openjdk.org/jdk/compare/76a1109d...1f439bec
>
> src/java.base/share/classes/java/util/LazyCollections.java line 199:
>
>> 197: final int size = base.size();
>> 198: subListRangeCheck(fromIndex, toIndex, size);
>> 199: return new ReverseOrderLazyListView<>(base.subList(size - toIndex, size - fromIndex));
>
> Why not this? (maybe add a comment?)
> Suggestion:
>
> return new ReverseOrderLazyListView<>(base.subList(fromIndex, toIndex));
Actually, now that toString() evaluates, we could just get rid of these classes and use the ones in the base class. Great!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27605#discussion_r2527855543
More information about the core-libs-dev
mailing list