RFR: 8333727: Use JOpt in jpackage to parse command line [v6]
Alexey Semenyuk
asemenyuk at openjdk.org
Fri Nov 14 18:28:17 UTC 2025
On Thu, 13 Nov 2025 00:42:27 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>>
>> MainResources.properties: remove unreferenced L10N key
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBundlingEnvironment.java line 49:
>
>> 47: .bundler(CREATE_MAC_APP_IMAGE, MacBundlingEnvironment::createAppImage)
>> 48: .bundler(CREATE_MAC_DMG, LazyLoad::dmgSysEnv, MacBundlingEnvironment::createDmdPackage)
>> 49: .bundler(CREATE_MAC_PKG, MacBundlingEnvironment::createPkgPackage));
>
> Do you know why `CREATE_MAC_PKG` does not need/use environment like `CREATE_MAC_DMG`?
For dmg packaging, we validate that hdiutil and osascript commands are available. We also need to find the SetFile utility that may be in multiple locations. For pkg, we assume pkgbuild and productbuild commands are available and don't do any validation. That is why we have [MacDmgSystemEnvironment](https://github.com/openjdk/jdk/blob/10f262a6ad9a6e89cd79409c5e1a3f7efda76928/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgSystemEnvironment.java) but don't have MacPkgSystemEnvironment.
Historically, pkg tools were not validated. We can change it in a separate CR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28163#discussion_r2528496058
More information about the core-libs-dev
mailing list