RFR: 8333727: Use JOpt in jpackage to parse command line [v6]
Alexander Matveev
almatvee at openjdk.org
Fri Nov 14 22:02:08 UTC 2025
On Fri, 14 Nov 2025 18:24:57 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBundlingEnvironment.java line 49:
>>
>>> 47: .bundler(CREATE_MAC_APP_IMAGE, MacBundlingEnvironment::createAppImage)
>>> 48: .bundler(CREATE_MAC_DMG, LazyLoad::dmgSysEnv, MacBundlingEnvironment::createDmdPackage)
>>> 49: .bundler(CREATE_MAC_PKG, MacBundlingEnvironment::createPkgPackage));
>>
>> Do you know why `CREATE_MAC_PKG` does not need/use environment like `CREATE_MAC_DMG`?
>
> For dmg packaging, we validate that hdiutil and osascript commands are available. We also need to find the SetFile utility that may be in multiple locations. For pkg, we assume pkgbuild and productbuild commands are available and don't do any validation. That is why we have [MacDmgSystemEnvironment](https://github.com/openjdk/jdk/blob/10f262a6ad9a6e89cd79409c5e1a3f7efda76928/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgSystemEnvironment.java) but don't have MacPkgSystemEnvironment.
>
> Historically, pkg tools were not validated. We can change it in a separate CR.
Thanks for explanation. Lets keep it this way.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28163#discussion_r2529082020
More information about the core-libs-dev
mailing list