RFR: 8372155: ReleaseInfoPlugin doesn't handle input file as UTF-8 properly [v5]

Alan Bateman alanb at openjdk.org
Mon Nov 24 15:33:40 UTC 2025


On Mon, 24 Nov 2025 15:13:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this simple fix to `jlink`'s `--release-info` plugin to handle non-ASCII in vendor strings. The JDK build uses UTF-8 encoding for the produced `release` file that is being passed to `jlink` at build-time via the `--release-info` plugin. However, the plugin internally uses `java.util.Properties.load(InputStream)` API which assumes `ISO-8859-1` encoding of the input stream. The proposed fix is to use the `java.util.Prorperties.load(Reader)` API instead and pass it a `Reader` with `UTF-8` encoding (using nio API).
>> 
>> Testing:
>> - [x] GHA
>> - [x] `test/jdk/tools/jlink` tests including the new reg-test which fails prior and passes after the fix.
>> 
>> Thoughts?
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reduce 'var' usage in test

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28399#pullrequestreview-3501003380


More information about the core-libs-dev mailing list