Integrated: 8372155: ReleaseInfoPlugin doesn't handle input file as UTF-8 properly
Severin Gehwolf
sgehwolf at openjdk.org
Mon Nov 24 22:18:47 UTC 2025
On Wed, 19 Nov 2025 17:47:07 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> Please review this simple fix to `jlink`'s `--release-info` plugin to handle non-ASCII in vendor strings. The JDK build uses UTF-8 encoding for the produced `release` file that is being passed to `jlink` at build-time via the `--release-info` plugin. However, the plugin internally uses `java.util.Properties.load(InputStream)` API which assumes `ISO-8859-1` encoding of the input stream. The proposed fix is to use the `java.util.Prorperties.load(Reader)` API instead and pass it a `Reader` with `UTF-8` encoding (using nio API).
>
> Testing:
> - [x] GHA
> - [x] `test/jdk/tools/jlink` tests including the new reg-test which fails prior and passes after the fix.
>
> Thoughts?
This pull request has now been integrated.
Changeset: 42b108b4
Author: Severin Gehwolf <sgehwolf at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/42b108b445b359e1d4b1043dbc1cbd42f551c19c
Stats: 93 lines in 3 files changed: 87 ins; 1 del; 5 mod
8372155: ReleaseInfoPlugin doesn't handle input file as UTF-8 properly
Reviewed-by: alanb, jpai
-------------
PR: https://git.openjdk.org/jdk/pull/28399
More information about the core-libs-dev
mailing list