RFR: 8364361: [process] java.lang.Process should implement Closeable [v14]

Alan Bateman alanb at openjdk.org
Sat Oct 4 06:24:48 UTC 2025


On Wed, 1 Oct 2025 17:45:41 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>> 
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>> 
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clarify the use of waitFor after close() or T-W-R exit.

src/java.base/share/classes/java/lang/Process.java line 197:

> 195:      * Closing an already closed stream usually has no effect but is specific to the stream.
> 196:      * If an {@code IOException} occurs when closing a stream it is
> 197:      * re-thrown after the process is terminated. Additional {@code IOExceptions}

"re-thrown", by what/who? Maybe use "this method" or "the close method" to make it clearer?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2403787162


More information about the core-libs-dev mailing list