RFR: 8364361: [process] java.lang.Process should implement Closeable [v14]

Alan Bateman alanb at openjdk.org
Sat Oct 4 06:29:46 UTC 2025


On Wed, 1 Oct 2025 17:45:41 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>> 
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>> 
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clarify the use of waitFor after close() or T-W-R exit.

src/java.base/share/classes/java/lang/Process.java line 202:

> 200:      * <p>
> 201:      * The process may already have terminated or be in the process of terminating;
> 202:      * if it is {@linkplain #isAlive() alive}, it is {@linkplain #destroy destroyed}.

The compound sentence is hard to read. It might be clear to say that the process is destroyed. This is no-op if the process has already terminated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2403788667


More information about the core-libs-dev mailing list