RFR: 8369123: Still more small Float16 refactorings [v2]
Eirik Bjørsnøs
eirbjo at openjdk.org
Sun Oct 5 09:29:47 UTC 2025
On Fri, 3 Oct 2025 22:12:19 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Upon further inspection, found a few more opportunities to refine the use of constants in the Float16 implementation.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove unneeded use of "Float16.".
> > ```
> > // IEEEremainder / remainder operator remainder
> > ```
> `IEEEremainder` differs from the Java language remainder operator, due to the difference in rounding policy.
Thanks for providing context, it makes the sentence easier to understand. I now parse "remainder operator remainder" as "the remainder function as defined by JVM drem/frem bytecodes".
The comment seems a bit terse in its current form, more of a note-to-self reminder of future implementation ideas. Usually comments refer to current functionality, so this was sticking out to me as somewhat unusual. @jddarcy may have an opinion here.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27625#issuecomment-3368894135
More information about the core-libs-dev
mailing list