RFR: 8369123: Still more small Float16 refactorings [v2]

Joe Darcy darcy at openjdk.org
Mon Oct 6 02:56:45 UTC 2025


On Sun, 5 Oct 2025 09:27:23 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> > > ```
> > > // IEEEremainder / remainder operator remainder
> > > ```
> 
> > `IEEEremainder` differs from the Java language remainder operator, due to the difference in rounding policy.
> 
> Thanks for providing context, it makes the sentence easier to understand. I now parse "remainder operator remainder" as "the remainder function as defined by JVM drem/frem bytecodes".
> 
> The comment seems a bit terse in its current form, more of a note-to-self reminder of future implementation ideas. Usually comments refer to current functionality, so this was sticking out to me as somewhat unusual. @jddarcy may have an opinion here.

You are correct that the comment is a note-to-self/note-to-future maintainers. I'll expand the note to give some more details on IEEE remainder vs % remainder.

I think occasional comments like this, which are only visible to readers of the source code of course, are acceptable in production code and also acceptable in incubating code like this.

Thanks for the careful reading.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27625#issuecomment-3369755566


More information about the core-libs-dev mailing list