RFR: 8369123: Still more small Float16 refactorings [v2]
Joe Darcy
darcy at openjdk.org
Mon Oct 6 20:29:46 UTC 2025
On Mon, 6 Oct 2025 08:02:24 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> > For the use of regex, is it an aesthetics question or a JDK bootstrapping question?
>
> Thanks for your consideration. This particular regex seems fine aesthetically.
>
> Having been bitten by performance suprises in the past, it raises my eyebrows when regex-dependent String functions are used in platform, library or otherwise low-level code. This looks like an edge-case, and as you note it is pre-existing. So yes, probably fine.
Use of regex does merit some scrutiny, easy to write a regex that can run in exponential time.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27625#issuecomment-3373929950
More information about the core-libs-dev
mailing list