RFR: 8369123: Still more small Float16 refactorings [v2]
Raffaello Giulietti
rgiulietti at openjdk.org
Tue Oct 7 15:48:06 UTC 2025
On Mon, 6 Oct 2025 20:26:54 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>>> For the use of regex, is it an aesthetics question or a JDK bootstrapping question?
>>
>> Thanks for your consideration. This particular regex seems fine aesthetically.
>>
>> Having been bitten by performance suprises in the past, it raises my eyebrows when regex-dependent String functions are used in platform, library or otherwise low-level code. This looks like an edge-case, and as you note it is pre-existing. So yes, probably fine.
>
>> > For the use of regex, is it an aesthetics question or a JDK bootstrapping question?
>>
>> Thanks for your consideration. This particular regex seems fine aesthetically.
>>
>> Having been bitten by performance suprises in the past, it raises my eyebrows when regex-dependent String functions are used in platform, library or otherwise low-level code. This looks like an edge-case, and as you note it is pre-existing. So yes, probably fine.
>
> Use of regex does merit some scrutiny, easy to write a regex that can run in exponential time.
@jddarcy To address @eirbjo concerns about using a regex, what about `s.replace("-1022", "-14")` instead? There should be no ambiguity in this specific case.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27625#issuecomment-3377503605
More information about the core-libs-dev
mailing list