RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v8]

Alexander Matveev almatvee at openjdk.org
Wed Oct 8 01:39:06 UTC 2025


On Wed, 8 Oct 2025 01:11:53 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v6]
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/OverridableResource.java line 237:
> 
>> 235:         Log.verbose(I18N.format("message.no-default-resource",
>> 236:                 publicName, getPrintableCategory(), publicName));
>> 237: 
> 
> I still believe this log message is misleading.

`[18:34:04.625] No default package resource postinstall [PKG postinstall script] (add postinstall to the resource-dir to customize).`
`[18:34:04.625] No default package resource preinstall [PKG preinstall script] (add preinstall to the resource-dir to customize).
`
This is example of log message. Do you have any suggestions on how to improve it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25510#discussion_r2412298119


More information about the core-libs-dev mailing list