RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v8]
Alexey Semenyuk
asemenyuk at openjdk.org
Wed Oct 8 02:20:07 UTC 2025
On Wed, 8 Oct 2025 01:36:03 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/OverridableResource.java line 237:
>>
>>> 235: Log.verbose(I18N.format("message.no-default-resource",
>>> 236: publicName, getPrintableCategory(), publicName));
>>> 237:
>>
>> I still believe this log message is misleading.
>
> `[18:34:04.625] No default package resource postinstall [PKG postinstall script] (add postinstall to the resource-dir to customize).`
> `[18:34:04.625] No default package resource preinstall [PKG preinstall script] (add preinstall to the resource-dir to customize).
> `
> This is example of log message. Do you have any suggestions on how to improve it?
This change adds the following log message:
[22:09:41.559] No default package resource null [script to run after application image is populated] (add null to the resource-dir to customize).
I can see it in PkgScriptsTest and in SimplePackageTest.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25510#discussion_r2412335312
More information about the core-libs-dev
mailing list