RFR: 8370775: ModulePatcher$JarResourceFinder.getByteBuffer() does not close the InputStream after reading the bytes [v2]
Jaikiran Pai
jpai at openjdk.org
Tue Oct 28 10:17:40 UTC 2025
On Tue, 28 Oct 2025 10:08:55 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Alan's suggestion - rename "is" to "in"
>
> src/java.base/share/classes/jdk/internal/module/ModulePatcher.java line 470:
>
>> 468: @Override
>> 469: public ByteBuffer getByteBuffer() throws IOException {
>> 470: try (InputStream is = getInputStream()) {
>
> Can you rename "is" to "in", only because "is" isn't a great name.
Done, in the updated version of this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28014#discussion_r2468881063
More information about the core-libs-dev
mailing list