RFR: 8370775: ModulePatcher$JarResourceFinder.getByteBuffer() does not close the InputStream after reading the bytes [v2]

Jaikiran Pai jpai at openjdk.org
Tue Oct 28 10:17:38 UTC 2025


> Can I please get a review of this code which closes the `InputStream` upon usage in `ModulePatcher$JarResourceFinder.getByteBuffer()`?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8370775, this is a minor clean up to this part of the code.
> 
> tier testing is currently in progress with this change.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Alan's suggestion - rename "is" to "in"

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28014/files
  - new: https://git.openjdk.org/jdk/pull/28014/files/83d95b09..f7f0c4f5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28014&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28014&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/28014.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28014/head:pull/28014

PR: https://git.openjdk.org/jdk/pull/28014


More information about the core-libs-dev mailing list