RFR: 8370775: ModulePatcher$JarResourceFinder.getByteBuffer() does not close the InputStream after reading the bytes [v2]

Alan Bateman alanb at openjdk.org
Tue Oct 28 10:21:08 UTC 2025


On Tue, 28 Oct 2025 10:17:38 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this code which closes the `InputStream` upon usage in `ModulePatcher$JarResourceFinder.getByteBuffer()`?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8370775, this is a minor clean up to this part of the code.
>> 
>> tier testing is currently in progress with this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan's suggestion - rename "is" to "in"

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28014#pullrequestreview-3387888096


More information about the core-libs-dev mailing list