RFR: 8366017: Extend the set of inputs handled by fast paths in FloatingDecimal [v6]

Joe Darcy darcy at openjdk.org
Wed Oct 29 04:21:04 UTC 2025


On Tue, 28 Oct 2025 11:03:00 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Yet another step in modernizing `FloatingDecimal`s floating-point parsing.
>
> Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 36 commits:
> 
>  - Merge branch 'master' into 8366017
>  - Added test for all float->String->float roundtrips.
>  - Merge branch 'master' into 8366017
>  - Added tests to exercise fast paths.
>  - Fix a rare bug.
>  - Merge branch 'master' into 8366017
>  - More complete benchmarks.
>  - JMH benchmarks.
>  - Adapted tests to more restricted access.
>  - Merge branch 'master' into 8366017
>  - ... and 26 more: https://git.openjdk.org/jdk/compare/96259936...c3485864

Marked as reviewed by darcy (Reviewer).

test/jdk/java/lang/Double/ParseDouble.java line 765:

> 763:     private static void testFastPaths() {
> 764:         /* Exercises the fast paths in jdk.internal.math.FloatingDecimal. */
> 765:         check("1", 1.0);

Something to consider: specify the double values in hex literals -- this would exercise entirely different code paths than the decimal ones.

-------------

PR Review: https://git.openjdk.org/jdk/pull/26990#pullrequestreview-3391609408
PR Review Comment: https://git.openjdk.org/jdk/pull/26990#discussion_r2471679731


More information about the core-libs-dev mailing list