RFR: 8366017: Extend the set of inputs handled by fast paths in FloatingDecimal [v6]
Raffaello Giulietti
rgiulietti at openjdk.org
Wed Oct 29 11:06:48 UTC 2025
On Wed, 29 Oct 2025 04:16:37 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 36 commits:
>>
>> - Merge branch 'master' into 8366017
>> - Added test for all float->String->float roundtrips.
>> - Merge branch 'master' into 8366017
>> - Added tests to exercise fast paths.
>> - Fix a rare bug.
>> - Merge branch 'master' into 8366017
>> - More complete benchmarks.
>> - JMH benchmarks.
>> - Adapted tests to more restricted access.
>> - Merge branch 'master' into 8366017
>> - ... and 26 more: https://git.openjdk.org/jdk/compare/96259936...c3485864
>
> test/jdk/java/lang/Double/ParseDouble.java line 765:
>
>> 763: private static void testFastPaths() {
>> 764: /* Exercises the fast paths in jdk.internal.math.FloatingDecimal. */
>> 765: check("1", 1.0);
>
> Something to consider: specify the double values in hex literals -- this would exercise entirely different code paths than the decimal ones.
Good point, I fully agree.
Updating the test to use hexadecimals...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26990#discussion_r2472575652
More information about the core-libs-dev
mailing list