RFR: 8365428: Unclear comments on java.lang.invoke Holder classes [v4]
Chen Liang
liach at openjdk.org
Fri Sep 5 00:00:34 UTC 2025
> java.lang.invoke has a few Holder classes in DirectMethodHandle, DelegatingMethodHandle, Invokers, and LambdaForm.
>
> Currently, the comments simply refer to "Placeholder for xxx generated ahead-of-time".
>
> However, they carry executed bytecode and show up in flame graphs. The current comments are definitely not sufficient for their details and purposes.
>
> To address these shortcomings, I improved the comments on the Holder classes and GenerateJLIClassesHelper to briefly describe the generation process. In addition, I improved the comments on BoundMethodHandle to provide a more efficient overview.
Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
Jorn review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27010/files
- new: https://git.openjdk.org/jdk/pull/27010/files/fa581ff3..c08ed390
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27010&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27010&range=02-03
Stats: 31 lines in 5 files changed: 0 ins; 24 del; 7 mod
Patch: https://git.openjdk.org/jdk/pull/27010.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27010/head:pull/27010
PR: https://git.openjdk.org/jdk/pull/27010
More information about the core-libs-dev
mailing list