RFR: 8365428: Unclear comments on java.lang.invoke Holder classes [v4]
Jorn Vernee
jvernee at openjdk.org
Fri Sep 5 01:51:14 UTC 2025
On Fri, 5 Sep 2025 00:00:34 GMT, Chen Liang <liach at openjdk.org> wrote:
>> java.lang.invoke has a few Holder classes in DirectMethodHandle, DelegatingMethodHandle, Invokers, and LambdaForm.
>>
>> Currently, the comments simply refer to "Placeholder for xxx generated ahead-of-time".
>>
>> However, they carry executed bytecode and show up in flame graphs. The current comments are definitely not sufficient for their details and purposes.
>>
>> To address these shortcomings, I improved the comments on the Holder classes and GenerateJLIClassesHelper to briefly describe the generation process. In addition, I improved the comments on BoundMethodHandle to provide a more efficient overview.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Jorn review
Marked as reviewed by jvernee (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/27010#pullrequestreview-3187769410
More information about the core-libs-dev
mailing list