RFR: 8366837: Clean up gensrc by spp.Spp

Magnus Ihse Bursie ihse at openjdk.org
Fri Sep 5 22:50:11 UTC 2025


On Fri, 5 Sep 2025 22:34:32 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Several java classes in java.base is generated from templates using SPP, the "Stream Preprocessor". Unfortunately much of this code is very old and has survived unchanged since pre-JDK 7. It does not follow modern makefile standards for abstraction, safe coding practices, etc. In short, they have been a thorn in the side for a long time, and the time has finally come to clean them up.
>
> make/modules/java.base/gensrc/GensrcBuffer.gmk line 162:
> 
>> 160: 	$$(CAT) $$($1_BIN_SNIPPET_FILES) >> $$($1_REAL_OUTPUT).tmp
>> 161: 	$$(ECHO) "}" >> $$($1_REAL_OUTPUT).tmp
>> 162: 	$$(MV) $$($1_REAL_OUTPUT).tmp $$($1_REAL_OUTPUT)
> 
> Indentation looks off here.

I think it is per our standard. It seems the Github diff viewer expands tabs to 4 spaces, which makes it looks incorrect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27078#discussion_r2326185455


More information about the core-libs-dev mailing list