RFR: 8366837: Clean up gensrc by spp.Spp

Magnus Ihse Bursie ihse at openjdk.org
Sat Sep 6 09:05:10 UTC 2025


On Fri, 5 Sep 2025 22:47:58 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/modules/java.base/gensrc/GensrcBuffer.gmk line 162:
>> 
>>> 160: 	$$(CAT) $$($1_BIN_SNIPPET_FILES) >> $$($1_REAL_OUTPUT).tmp
>>> 161: 	$$(ECHO) "}" >> $$($1_REAL_OUTPUT).tmp
>>> 162: 	$$(MV) $$($1_REAL_OUTPUT).tmp $$($1_REAL_OUTPUT)
>> 
>> Indentation looks off here.
>
> I think it is per our standard. It seems the Github diff viewer expands tabs to 4 spaces, which makes it looks incorrect.

Turns out you can actually change the tab size setting on GitHub. They set 4 as default but you can change it to 8 at https://github.com/settings/appearance.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27078#discussion_r2326684556


More information about the core-libs-dev mailing list